-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module-federation): Throw an error if remote is invalid #23100
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4571f5d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
2a9fbbd
to
262d90c
Compare
35f0439
to
aae6275
Compare
aae6275
to
4571f5d
Compare
If you are generating a remote using `--dynamic` either by using the `host` generator or the `remote` generator we now check to ensure that the remote name is a valid JavaScript variable. If this is not done the app with be invalid and unable to be ran or bundled. closes: #23024 (cherry picked from commit 0322b98)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
If you are generating a remote using
--dynamic
either by using thehost
generator or theremote
generator we now check to ensure that the remote name is a valid JavaScript variable.If this is not done the app with be invalid and unable to be ran or bundled.
closes: #23024